Merged
Conversation
sebastianvitterso
approved these changes
Feb 28, 2025
Contributor
sebastianvitterso
left a comment
sebastianvitterso
left a comment
There was a problem hiding this comment.
One question, otherwise good!
Contributor
|
@mariuswinger is this still relevant or has it become stale? |
Contributor
Author
|
Probably super stale. But looks like the underlying still is relevant. Unit tests do not depend on docker, so they can be ran outside of docker via e.g. |
mariuswinger
force-pushed
the
ci/unit-tests-outside-of-docker
branch
from
c79034b to
99c0835
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed?
Unit tests in python are not dependant on docker. They can be ran by using poetry and setup-python caching.